xZero707/droidfish
1
0
Fork 0
mirror of https://github.com/peterosterlund2/droidfish.git synced 2025-12-08 15:12:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

DroidFish: Fixed potential null pointer dereferences.

Browse Source
This commit is contained in:
Peter Osterlund
2017-01-19 22:58:15 +01:00
parent 1011506cea
commit 91c6a39bb7
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
DroidFish/src/org/petero/droidfish/activities/EditPGN.java
View File

@@ -275,7 +275,7 @@ public class EditPGN extends ListActivity {
@Override @Override
public boolean onItemLongClick(AdapterView<?> parent, View view, int pos, long id) { public boolean onItemLongClick(AdapterView<?> parent, View view, int pos, long id) {
selectedGi = aa.getItem(pos); selectedGi = aa.getItem(pos);
if (!selectedGi.isNull()) { if (selectedGi != null && !selectedGi.isNull()) {
removeDialog(DELETE_GAME_DIALOG); removeDialog(DELETE_GAME_DIALOG);
showDialog(DELETE_GAME_DIALOG); showDialog(DELETE_GAME_DIALOG);
} }
@@ -334,6 +334,8 @@ public class EditPGN extends ListActivity {
case DELETE_GAME_DIALOG: { case DELETE_GAME_DIALOG: {
final GameInfo gi = selectedGi; final GameInfo gi = selectedGi;
selectedGi = null; selectedGi = null;
if (gi == null)
return null;
AlertDialog.Builder builder = new AlertDialog.Builder(this); AlertDialog.Builder builder = new AlertDialog.Builder(this);
builder.setTitle(R.string.delete_game); builder.setTitle(R.string.delete_game);
String msg = gi.toString(); String msg = gi.toString();
@@ -355,6 +357,8 @@ public class EditPGN extends ListActivity {
case SAVE_GAME_DIALOG: { case SAVE_GAME_DIALOG: {
final GameInfo gi = selectedGi; final GameInfo gi = selectedGi;
selectedGi = null; selectedGi = null;
if (gi == null)
return null;
AlertDialog.Builder builder = new AlertDialog.Builder(this); AlertDialog.Builder builder = new AlertDialog.Builder(this);
builder.setTitle(R.string.save_game_question); builder.setTitle(R.string.save_game_question);
final CharSequence[] items = { final CharSequence[] items = {